fix: stop-using-index-to-access-update-segment (#5960)

Author: Zaimwa9

frontend/e2e/helpers.cafe.ts

@@ -66,6 +66,15 @@ export const waitForElementClickable = async (selector: string) => {
   await t.expect(Selector(selector).hasAttribute('disabled')).notOk()
 }
 
+export const clickSegmentByName = async (name: string) => {
+   const el = Selector('[data-test^="segment-"][data-test$="-name"]').withText(
+      name,
+   )
+   await t.scrollIntoView(el)
+   await t.expect(el.visible).ok(`segment "${name}" not visible`, { timeout: LONG_TIMEOUT })
+   await t.click(el)
+  }
+  
 export const logResults = async (requests: LoggedRequest[], t) => {
   if (!t.testRun?.errs?.length) {
     log('Finished without errors')
@@ -78,7 +87,8 @@ export const logResults = async (requests: LoggedRequest[], t) => {
       requests.filter((v) => {
         if (
           v.request?.url?.includes('get-subscription-metadata') ||
-          v.request?.url?.includes('analytics/flags')
+          v.request?.url?.includes('analytics/flags') ||
+          v.request?.url?.includes('/usage-data?')
         ) {
           return false
         }
@@ -132,6 +142,7 @@ export const clickByText = async (text: string, element = 'button') => {
 
 export const gotoSegments = async () => {
   await click('#segments-link')
+  await waitForElementVisible(byId('show-create-segment-btn'))
 }
 
 export const getLogger = () =>

frontend/e2e/tests/segment-test.ts

@@ -28,6 +28,7 @@ import {
   cloneSegment,
   setSegmentRule,
   assertInputValue,
+  clickSegmentByName,
 } from '../helpers.cafe'
 import { E2E_USER, PASSWORD } from '../config'
 
@@ -145,19 +146,22 @@ export const testSegment1 = async (flagsmith: any) => {
   await deleteFeature(0, 'mv_flag')
 
   log('Update segment')
+  const SEGMENT_TO_UPDATE_NAME = 'segment_to_update'
   await gotoSegments()
   const lastRule = segmentRules[segmentRules.length - 1]
-  await createSegment(0, 'segment_to_update', [lastRule])
+  await createSegment(0, SEGMENT_TO_UPDATE_NAME, [lastRule])
   await closeModal()
-  await click(byId('segment-0-name'))
+  await waitAndRefresh()
+  await clickSegmentByName(SEGMENT_TO_UPDATE_NAME)
   await setSegmentRule(0, 0, lastRule.name, lastRule.operator, lastRule.value + 1)
   await click(byId('update-segment'))
   await closeModal()
-  await gotoSegments()
-  await click(byId('segment-0-name'))
+  await waitAndRefresh()
+  await clickSegmentByName(SEGMENT_TO_UPDATE_NAME)
   await assertInputValue(byId(`rule-${0}-value-0`), `${lastRule.value + 1}`)
   await closeModal()
-  await deleteSegment(0, 'segment_to_update', !isCloneSegmentEnabled)
+  await waitAndRefresh()
+  await deleteSegment(0, SEGMENT_TO_UPDATE_NAME, !isCloneSegmentEnabled)
   await waitAndRefresh()
 }