fix: Set Hubspot id to newest value #5040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Docker builds report
|
|
Uffizzi Preview |
zachaysan
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5040 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 1193 1193
Lines 41675 41692 +17
=======================================
+ Hits 40593 40610 +17
Misses 1082 1082 ☔ View full report in Codecov by Sentry. |
matthewelwell
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Sometimes Hubspot identifiers are set for already existing users. This allows those users to have an updated Hubspot lead tracking objects to the latest Hubspot identifiers.
How did you test this code?
One new, long test which checks for the pre-presence of the Hubspot tracking then checks to make sure that the user is properly registered without the presence of the former Hubspot tracking identifier.