Skip to content

Commit 0fe2b0d

Browse files
authored
chore: manage PVCs within the workload (#9664)
1 parent 84e8169 commit 0fe2b0d

16 files changed

+53
-551
lines changed

cmd/manager/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ func main() {
482482
Client: client,
483483
Scheme: mgr.GetScheme(),
484484
Recorder: mgr.GetEventRecorderFor("component-controller"),
485-
}).SetupWithManager(mgr, multiClusterMgr); err != nil {
485+
}).SetupWithManager(mgr); err != nil {
486486
setupLog.Error(err, "unable to create controller", "controller", "Component")
487487
os.Exit(1)
488488
}

controllers/apps/cluster/transformer_cluster_deletion.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ func (t *clusterDeletionTransformer) Transform(ctx graph.TransformContext, dag *
133133
if isOwnedByComp(o) || appsutil.IsOwnedByInstanceSet(o) {
134134
continue
135135
}
136-
graphCli.Delete(dag, o, appsutil.InUniversalContext4G())
136+
graphCli.Delete(dag, o)
137137
}
138138

139139
// set cluster action to status until all the sub-resources deleted

controllers/apps/cluster/utils.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import (
3030

3131
appsv1 "github.com/apecloud/kubeblocks/apis/apps/v1"
3232
dpv1alpha1 "github.com/apecloud/kubeblocks/apis/dataprotection/v1alpha1"
33-
appsutil "github.com/apecloud/kubeblocks/controllers/apps/util"
3433
"github.com/apecloud/kubeblocks/pkg/constant"
3534
"github.com/apecloud/kubeblocks/pkg/controller/model"
3635
dptypes "github.com/apecloud/kubeblocks/pkg/dataprotection/types"
@@ -95,14 +94,14 @@ func getOwningNamespacedObjects(ctx context.Context,
9594
labels client.MatchingLabels,
9695
kinds []client.ObjectList) (owningObjects, error) {
9796
inNS := client.InNamespace(namespace)
98-
return getOwningObjectsWithOptions(ctx, cli, kinds, inNS, labels, appsutil.InUniversalContext4C())
97+
return getOwningObjectsWithOptions(ctx, cli, kinds, inNS, labels)
9998
}
10099

101100
func getOwningNonNamespacedObjects(ctx context.Context,
102101
cli client.Reader,
103102
labels client.MatchingLabels,
104103
kinds []client.ObjectList) (owningObjects, error) {
105-
return getOwningObjectsWithOptions(ctx, cli, kinds, labels, appsutil.InUniversalContext4C())
104+
return getOwningObjectsWithOptions(ctx, cli, kinds, labels)
106105
}
107106

108107
func getOwningObjectsWithOptions(ctx context.Context,

controllers/apps/component/component_controller.go

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ import (
4141
workloads "github.com/apecloud/kubeblocks/apis/workloads/v1"
4242
appsutil "github.com/apecloud/kubeblocks/controllers/apps/util"
4343
"github.com/apecloud/kubeblocks/pkg/constant"
44-
"github.com/apecloud/kubeblocks/pkg/controller/multicluster"
4544
intctrlutil "github.com/apecloud/kubeblocks/pkg/controllerutil"
4645
viper "github.com/apecloud/kubeblocks/pkg/viperx"
4746
)
@@ -190,18 +189,12 @@ func (r *ComponentReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
190189
}
191190

192191
// SetupWithManager sets up the controller with the Manager.
193-
func (r *ComponentReconciler) SetupWithManager(mgr ctrl.Manager, multiClusterMgr multicluster.Manager) error {
192+
func (r *ComponentReconciler) SetupWithManager(mgr ctrl.Manager) error {
194193
retryDurationMS := viper.GetInt(constant.CfgKeyCtrlrReconcileRetryDurationMS)
195194
if retryDurationMS != 0 {
196195
appsutil.RequeueDuration = time.Millisecond * time.Duration(retryDurationMS)
197196
}
198-
if multiClusterMgr == nil {
199-
return r.setupWithManager(mgr)
200-
}
201-
return r.setupWithMultiClusterManager(mgr, multiClusterMgr)
202-
}
203197

204-
func (r *ComponentReconciler) setupWithManager(mgr ctrl.Manager) error {
205198
b := intctrlutil.NewControllerManagedBy(mgr).
206199
For(&appsv1.Component{}).
207200
WithOptions(controller.Options{
@@ -211,8 +204,7 @@ func (r *ComponentReconciler) setupWithManager(mgr ctrl.Manager) error {
211204
Owns(&corev1.Service{}).
212205
Owns(&corev1.Secret{}).
213206
Owns(&corev1.ConfigMap{}).
214-
Watches(&dpv1alpha1.Restore{}, handler.EnqueueRequestsFromMapFunc(r.filterComponentResources)).
215-
Watches(&corev1.PersistentVolumeClaim{}, handler.EnqueueRequestsFromMapFunc(r.filterComponentResources))
207+
Watches(&dpv1alpha1.Restore{}, handler.EnqueueRequestsFromMapFunc(r.filterComponentResources))
216208

217209
if viper.GetBool(constant.EnableRBACManager) {
218210
b.Owns(&rbacv1.RoleBinding{}).
@@ -223,26 +215,6 @@ func (r *ComponentReconciler) setupWithManager(mgr ctrl.Manager) error {
223215
return b.Complete(r)
224216
}
225217

226-
func (r *ComponentReconciler) setupWithMultiClusterManager(mgr ctrl.Manager, multiClusterMgr multicluster.Manager) error {
227-
b := intctrlutil.NewControllerManagedBy(mgr).
228-
For(&appsv1.Component{}).
229-
WithOptions(controller.Options{
230-
MaxConcurrentReconciles: viper.GetInt(constant.CfgKBReconcileWorkers),
231-
}).
232-
Owns(&workloads.InstanceSet{}).
233-
Watches(&dpv1alpha1.Restore{}, handler.EnqueueRequestsFromMapFunc(r.filterComponentResources))
234-
235-
eventHandler := handler.EnqueueRequestsFromMapFunc(r.filterComponentResources)
236-
multiClusterMgr.Watch(b, &corev1.Service{}, eventHandler).
237-
Watch(b, &corev1.Secret{}, eventHandler).
238-
Watch(b, &corev1.ConfigMap{}, eventHandler).
239-
Watch(b, &corev1.PersistentVolumeClaim{}, eventHandler).
240-
Watch(b, &corev1.ServiceAccount{}, eventHandler).
241-
Watch(b, &rbacv1.RoleBinding{}, eventHandler)
242-
243-
return b.Complete(r)
244-
}
245-
246218
func (r *ComponentReconciler) filterComponentResources(ctx context.Context, obj client.Object) []reconcile.Request {
247219
labels := obj.GetLabels()
248220
if v, ok := labels[constant.AppManagedByLabelKey]; !ok || v != constant.AppName {

0 commit comments

Comments
 (0)