How do I edit values in Query and Headers?

[skrobul]

This might be stupid question, but I went through docs and tried every key combination I could think of, but I am not able to find a way to edit values after adding a Header or a Query parameter. Editing seems to work well when URL field is focused, but as soon as I move elsewhere it stops working.
What am I doing wrong?

[skrobul]

ok just found a feature request suggesting that this is not possible - #164
This is surprising as I'd consider editing headers to be be pretty common task in tools like this, but I guess beggars can't be choosers - I'll try to find some time to work on a PR

[kkHAIKE]

@darrenburns

I have come up with a solution, where the main idea is to modify KeyValueInput to support an Update feature:

When the table receives an enter_press or double_click event, it triggers a row_update message.

The row_update message contains (rowkey, key, value).
When KeyValueEditor receives the row_update message, it switches KeyValueInput into edit mode and fills in the key and value.

When KeyValueInput is in edit mode:

The Add button changes to an Update button.
It cannot lose focus unless you exit edit mode using the Esc key.
Pressing enter or clicking the Update button will send an update message, exit edit mode, and clear the input fields.
When KeyValueEditor receives the update message, it updates the key/value in the table.

[darrenburns]

@kkHAIKE I like it!

While the KeyValueEditor is in edit mode, I wonder if, as you type in the Input, the table row that is being edited updates in real time? The text could be highlighted orange or yellow or something, to indicate that row is being edited. I'd like there to be some way of indicating which row is being edited, at a glance.

If I press escape, the row reverts to the original version (from before entering edit mode). If I press enter, it "commits" the change to the row.

[darrenburns]

Is this something you'd like to work on @kkHAIKE? I think it's probably near the top of priorities at the moment 🙂

[kkHAIKE]

Is this something you'd like to work on @kkHAIKE? I think it's probably near the top of priorities at the moment 🙂

It might be a while before I have the time to work on it. When I do, I'll submit a WIP PR.

[kkHAIKE]

@darrenburns Just got some free time, but found that this feature has already been implemented—looks really cool!

However, wouldn't it be better to enter edit mode via double-clicking the mouse? Since there's a need to toggle selections with press space after a single click.
😊

[darrenburns]

Yes, that'd probably be better but is a bit tricky to implement at the moment as the DataTable events from Textual don't include the "chain" attribute from the Click event.