Log parameter objects are now turned into String via toString (#4515)

* Add user id, username and email to log attributes

* wip

* Check log event count before sending envelope

* changelog

* Min event level config option; enable logs in logback sample

* review feedback

* treat unformatted message and params as pii if logback encoder is present

* Use toString for turning log param objects into strings

* Format code

* changelog

---------

Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>

Author: adinauer

CHANGELOG.md

@@ -10,6 +10,8 @@
 
 - No longer send out empty log envelopes ([#4497](https://github.com/getsentry/sentry-java/pull/4497))
 - Session Replay: Expand fix for crash on devices to all Unisoc/Spreadtrum chipsets ([#4510](https://github.com/getsentry/sentry-java/pull/4510))
+- Log parameter objects are now turned into `String` via `toString` ([#4515](https://github.com/getsentry/sentry-java/pull/4515))
+  - One of the two `SentryLogEventAttributeValue` constructors did not convert the value previously.
 
 ### Features
 
@@ -29,7 +31,7 @@
       <minimumEventLevel>WARN</minimumEventLevel>
       <!-- Default for Breadcrumbs is INFO -->
       <minimumBreadcrumbLevel>DEBUG</minimumBreadcrumbLevel>
-      <!-- Default for Breadcrumbs is INFO -->
+      <!-- Default for Log Events is INFO -->
       <minimumLevel>INFO</minimumLevel>
     </appender>
     ```

sentry/src/main/java/io/sentry/SentryLogEventAttributeValue.java

@@ -24,8 +24,7 @@ public SentryLogEventAttributeValue(final @NotNull String type, final @Nullable
 
   public SentryLogEventAttributeValue(
       final @NotNull SentryAttributeType type, final @Nullable Object value) {
-    this.type = type.apiName();
-    this.value = value;
+    this(type.apiName(), value);
   }
 
   public @NotNull String getType() {

sentry/src/test/java/io/sentry/protocol/SentryLogsSerializationTest.kt

@@ -6,6 +6,7 @@ import io.sentry.ILogger
 import io.sentry.JsonObjectReader
 import io.sentry.JsonObjectWriter
 import io.sentry.JsonSerializable
+import io.sentry.SentryAttributeType
 import io.sentry.SentryLogEvent
 import io.sentry.SentryLogEventAttributeValue
 import io.sentry.SentryLogEvents
@@ -39,6 +40,8 @@ class SentryLogsSerializationTest {
                   "sentry.trace.parent_span_id" to
                     SentryLogEventAttributeValue("string", "f28b86350e534671"),
                   "custom.boolean" to SentryLogEventAttributeValue("boolean", true),
+                  "custom.point2" to
+                    SentryLogEventAttributeValue(SentryAttributeType.STRING, Point(21, 31)),
                   "custom.double" to SentryLogEventAttributeValue("double", 11.12.toDouble()),
                   "custom.point" to SentryLogEventAttributeValue("string", Point(20, 30)),
                   "custom.integer" to SentryLogEventAttributeValue("integer", 10),

sentry/src/test/resources/json/sentry_logs.json

@@ -34,6 +34,10 @@
           "type": "boolean",
           "value": true
         },
+        "custom.point2": {
+          "type": "string",
+          "value": "Point{x:21,y:31}-Hello"
+        },
         "custom.double": {
           "type": "double",
           "value": 11.12