-
Notifications
You must be signed in to change notification settings - Fork 4.5k
build: update toolchain to go 1.23.12 and fix linter #22547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreeram77
requested changes
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dduzgun-security linter workflow seems to be failing. Could you please take a look at it?
@srikrishmurthy it should be fixed now |
sreeram77
approved these changes
Aug 12, 2025
7 tasks
sreeram77
added a commit
that referenced
this pull request
Aug 12, 2025
* build: update toolchain to go 1.23.12 * add changelog * bump again * fix lint * fix missing lint alerts * fix linter * bump golangci-lint to v8.0.0 * bump linter version --------- Co-authored-by: Sreeram Narayanan <sreeram.narayanan@hashicorp.com>
sreeram77
added a commit
that referenced
this pull request
Aug 12, 2025
… release/1.21.x (#22565) build: update toolchain to go 1.23.12 and fix linter (#22547) * build: update toolchain to go 1.23.12 * add changelog * bump again * fix lint * fix missing lint alerts * fix linter * bump golangci-lint to v8.0.0 * bump linter version --------- Co-authored-by: Deniz Onur Duzgun <59659739+dduzgun-security@users.noreply.github.com> Co-authored-by: Sreeram Narayanan <sreeram.narayanan@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/all
Apply backports for all active releases per .release/versions.hcl
backport/ent/1.18
Changes are backported to 1.18 ent
backport/ent/1.19
Changes are backported to 1.19 ent
backport/ent/1.20
backport to ent 1.20
backport/ent/1.21
changes are backported to 1.21 ent
backport/1.21
Changes are backported to 1.21
pr/dependencies
PR specifically updates dependencies of project
theme/api
Relating to the HTTP API interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pick up the Go toolchain update for 1.23.12.
Resolves CVE-2025-47906 vulnerability in os/exec LookPath function.
Fix linter
Testing & Reproduction steps
Links
PR Checklist
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.