Skip to content

Commit 42abed1

Browse files
Merge pull request #328 from dtantsur/release-manifest
🌱 Make the CI job run on the local source again
2 parents b3d2984 + 74f94d3 commit 42abed1

File tree

4 files changed

+6
-16
lines changed

4 files changed

+6
-16
lines changed

Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@ ifeq ($(USE_IMAGE_DIGESTS), true)
7272
endif
7373

7474
# Image URL to use all building/pushing image targets
75-
IMG ?= quay.io/metal3-io/ironic-standalone-operator:latest
75+
IMG_NO_TAG ?= quay.io/metal3-io/ironic-standalone-operator
76+
IMG ?= $(IMG_NO_TAG):latest
7677

7778
# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
7879
ifeq (,$(shell go env GOBIN))
@@ -332,6 +333,6 @@ release:
332333
@if [ -z "${RELEASE_TAG}" ]; then echo "RELEASE_TAG is not set"; exit 1; fi
333334
@if ! [ -z "$$(git status --porcelain)" ]; then echo "You have uncommitted changes"; exit 1; fi
334335
git checkout "${RELEASE_TAG}"
335-
sed -i -Ee "/image/s/(latest|release-[0-9\\.]+)/$(RELEASE_TAG)/" ./config/default/manager_image_patch.yaml
336+
cd config/manager && $(KUSTOMIZE) edit set image quay.io/metal3-io/ironic-standalone-operator="$(IMG_NO_TAG):${RELEASE_TAG}"
336337
$(MAKE) release-manifests
337338
$(MAKE) release-notes

config/default/kustomization.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ resources:
1212
#- ../prometheus
1313

1414
patches:
15-
- path: manager_image_patch.yaml
1615
- path: manager_webhook_patch.yaml
1716
- path: webhookcainjection_patch.yaml
1817

config/default/manager_image_patch.yaml

Lines changed: 0 additions & 11 deletions
This file was deleted.

docs/releasing.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ Create a development branch (e.g. `prepare-0.x`) from the newly created branch:
9090
branch of the Ironic image.
9191

9292
- Change the branch of IrSO itself from `latest` to `release-0.x` in two
93-
places: [IMG in Makefile][img-makefile] and in the file
94-
`config/default/manager_image_patch.yaml`.
93+
places: [IMG in Makefile][img-makefile] and
94+
[Kustomize configuration][kustomize].
9595

9696
- Commit your changes, push the new branch and create a pull request:
9797
- The commit and PR title should be
@@ -105,6 +105,7 @@ Wait for the pull request to be merged before proceeding.
105105

106106
[default-version]: https://github.com/metal3-io/ironic-standalone-operator/blob/b630805cdd782a51845fc16086e5f64fa77e29af/pkg/ironic/version.go#L14-L15
107107
[img-makefile]: https://github.com/metal3-io/ironic-standalone-operator/blob/b630805cdd782a51845fc16086e5f64fa77e29af/Makefile#L74-L75
108+
[kustomize]: https://github.com/metal3-io/ironic-standalone-operator/blob/b630805cdd782a51845fc16086e5f64fa77e29af/config/manager/manager.yaml#L47
108109

109110
### Creating Release Notes
110111

0 commit comments

Comments
 (0)