Skip to content

Commit 615ab08

Browse files
authored
Fix eval saving failing on -n -1 (#255)
1 parent 85ae8e4 commit 615ab08

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

verifiers/scripts/eval.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,7 @@ def eval_environment(
116116
print(out)
117117

118118
if save_dataset or save_to_hf_hub:
119-
ids = [
120-
i // rollouts_per_example
121-
for i in range(num_examples * rollouts_per_example)
122-
]
119+
ids = [i // rollouts_per_example for i in range(n * rollouts_per_example)]
123120
rewards = results.reward
124121
tasks = results.task
125122
data_dict = {
@@ -141,7 +138,7 @@ def eval_environment(
141138
metadata = {
142139
"env": env,
143140
"model": model,
144-
"num_examples": num_examples,
141+
"num_examples": n,
145142
"rollouts_per_example": rollouts_per_example,
146143
"sampling_args": merged_sampling_args,
147144
"date": datetime.now().strftime("%Y-%m-%d"),
@@ -170,7 +167,9 @@ def eval_environment(
170167
print(f"Saved dataset to {results_path}")
171168
if save_to_hf_hub:
172169
if hf_hub_dataset_name == "":
173-
dataset_name = f"{env}_{model.replace('/', '-')}_n{num_examples}_r{rollouts_per_example}"
170+
dataset_name = (
171+
f"{env}_{model.replace('/', '-')}_n{n}_r{rollouts_per_example}"
172+
)
174173
else:
175174
dataset_name = hf_hub_dataset_name
176175
dataset.push_to_hub(dataset_name)

0 commit comments

Comments
 (0)