Replies: 1 comment
-
if anyone wonders, i figured out a better way to solve my original setup. instead of passing this makes the generation a one-time cost. after the first run, it's instant, so the env doesn't need to know how many examples are being run anymore. it completely removes the need for the would still be nice to know everyone's thoughts on forward matching env args though. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
hey,
right now if my
load_environment
function needs to know something likenum_examples
(say i want to pre-process just a slice of the dataset, or the env needs some other vf-eval arg for some reason), i have to pass it twice.example:
uv run vf-eval my-env -n 10 -a '{"num_examples": 10}'
idea / question
i was wondering if it could make sense for
vf-eval
to auto-pass its own args toload_environment
when they match the function signature (and only when they match).so in this case, since my function takes
num_examples
, vf-eval could forward-n
automatically. then i would only need:the same could apply to args like
model
,temperature
, etc.trade-offs / concerns
possible naming collisions (e.g.
model
could mean different things in env vs eval), it could break some existing envs. also makes the boundary between env config and eval params fuzzier.curious if the current explicit design is intentional to keep that separation. would love to hear your reasoning.
i thought of this while building a multi-turn env that pre-generates the initial user messages, and i noticed i have to repeat params like this so it doesn't take too long.
I'd be glad to open a PR if this seems reasonable
thanks!
Beta Was this translation helpful? Give feedback.
All reactions