Aos 2 approximate unbounded efif #9036
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ximate_2 concept documentation
afabri
reviewed
Aug 22, 2025
| * approximates the curve. | ||
| * \param oi An output iterator for the output containers. | ||
| * \param bbox the bounding box. | ||
| * \param l2r A Boolean flag that indicates whether the curve direction is |
There was a problem hiding this comment.
Suggested change
| * \param l2r A Boolean flag that indicates whether the curve direction is | |
| * \param l2r A %Boolean flag that indicates whether the curve direction is |
|
I do not see a |
afabri
reviewed
Aug 22, 2025
| * `p`'s \f$y\f$-coordinate (if `i == 1`). | ||
| * \pre `i` is either 0 or 1. | ||
| */ | ||
| CGAL::Approximate_number_type operator()(AosTraits::Point_2 p, int i); |
There was a problem hiding this comment.
Do you really want to introduce CGAL::Approximate_number_type???
afabri
reviewed
Aug 22, 2025
| @@ -1517,9 +1518,24 @@ class Arr_linear_traits_2 : public Kernel_ { | |||
|
|
|||
| /// \name Functor definitions for the landmarks point-location strategy. | |||
| //@{ | |||
| typedef double Approximate_number_type; | |||
| typedef double Approximate_number_type; | |||
| typedef CGAL::Cartesian<Approximate_number_type> Approximate_kernel; | |||
There was a problem hiding this comment.
Is Cartesian better suited than Simple_cartesian?
afabri
reviewed
Aug 22, 2025
| @@ -17,6 +17,8 @@ | |||
| * \cgalHasModelsEnd | |||
| * | |||
| * \sa `AosApproximatePointTraits_2` | |||
| * \sa `AosConstructXMonotoneCurveTraits_2` | |||
| * \sa `AosXMonotoneTraits_2` | |||
| * \sa `draw()` | |||
|
For the approximation business, wouldn't it be reasonable to use the |
|
`AosApproximateTraits_2` refines `AosApproximatePointTraits_2`.
The latter has:
typedef unspecified_type
<https://www.cs.tau.ac.il/~efif/doc_output12/Manual/classunspecified__type.html>
Approximate_number_type
<https://www.cs.tau.ac.il/~efif/doc_output12/Arrangement_on_surface_2/classAosApproximatePointTraits__2.html#a0e381023f2dd60fd9a7118d9ac8d6c64>
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Fri, 22 Aug 2025 at 12:22, Andreas Fabri ***@***.***> wrote:
*afabri* left a comment (CGAL/cgal#9036)
<#9036 (comment)>
I do not see a typedef ... Approximate_number_type in the models of the
concept
<https://www.cs.tau.ac.il/~efif/doc_output12/Arrangement_on_surface_2/classAosApproximateTraits__2.html>
—
Reply to this email directly, view it on GitHub
<#9036 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNODLL5KOGEUS6E4HRLL3O3OODAVCNFSM6AAAAACEJIMON2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJTGY4TMNBQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
On Fri, 22 Aug 2025 at 12:30, Andreas Fabri ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/Concepts/AosTraits--ApproximatePoint_2.h
<#9036 (comment)>:
> + * \cgalHasModelsBegin
+ * \cgalHasModels{AosApproximatePointTraits_2::Approximate_2}
+ * \cgalHasModels{AosApproximateTraits_2::Approximate_2}
+ * \cgalHasModelsEnd
+ */
+class ApproximatePoint_2 {
+public:
+ /// \name Operations
+ /// A model of this concept must provide:
+ /// @{
+
+ /*! obtains an approximation of `p`'s \f$x\f$-coordinate (if `i == 0`), or of
+ * `p`'s \f$y\f$-coordinate (if `i == 1`).
+ * \pre `i` is either 0 or 1.
+ */
+ CGAL::Approximate_number_type operator()(AosTraits::Point_2 p, int i);
Do you really want to introduce CGAL::Approximate_number_type???
No, this is a mistake. Should be without the namespace of course.
I fixed it.
… —
Reply to this email directly, view it on GitHub
<#9036 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOATNLGJWPKWC3452PL3O3PL5AVCNFSM6AAAAACEJIMON2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCNBTG44TKOJSGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yes, it makes sense to use it in the implementation.
I think that the following traits classes can benefit from this:
- Arr_circle_segment_traits_2.h (maybe)
- Arr_conic_traits_2.h (maybe)
- Arr_geodesic_arc_on_sphere_traits_2.h (maybe)
- Arr_linear_traits_2.h
- Arr_non_caching_segment_basic_traits_2.h
- Arr_segment_traits_2.h
I'll go ahead and adapt it.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Fri, 22 Aug 2025 at 13:20, Andreas Fabri ***@***.***> wrote:
*afabri* left a comment (CGAL/cgal#9036)
<#9036 (comment)>
For the approximation business, wouldn't it be reasonable to use the
CGAL::Cartesian_coverter
<https://doc.cgal.org/latest/Kernel_23/classCGAL_1_1Cartesian__converter.html>
?
—
Reply to this email directly, view it on GitHub
<#9036 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOBUVIIGYFJ5FQ32W4D3O3VH5AVCNFSM6AAAAACEJIMON2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJTHA3DKNJYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Enhanced the drawing capabilities to draw arrangements induced by unbounded curves. This small feature consists of (i) additional draw() overloads for arrangements that also accepts a bounding box, and (ii) an additional requirement from the geometry traits for an operator that approximates a curve and also accepts a bounding box.
Release Management