Upgraded Vulkan version to 1.4.321.0 #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjondev
commented
Aug 21, 2025
| @@ -281,7 +282,7 @@ setup_moltenVk() { | |||
| checkout_tags "${VULKAN_VENDOR_DIR}"/MoltenVK ${MOLTENVK_VERSION} | |||
|
|
|||
| echo "Building MoltenVk..." | |||
| (cd "${VULKAN_VENDOR_DIR}"/MoltenVK ; ./fetchDependencies --macos --v-headers-root "${VULKAN_VENDOR_DIR}"/Vulkan-Headers --glslang-root "${VENDOR_DIR}"/glslang) | |||
| (cd "${VULKAN_VENDOR_DIR}"/MoltenVK ; ./fetchDependencies --macos) | |||
There was a problem hiding this comment.
@Raelr it seems the fetchDependencies script has been changed and the --glslang-root argument has been removed. The only arguments it now supports is --spirv-tools-root <path>, --build-spirv-tools, --spirv-cross-root <path>, and --v-headers-root <path>. Providing any combination of those arguments results in compilation errors. This should probably be looked into before we proceed.
Otherwise everything seems to build and compile with with and without validation layers enabled.
jonjondev
force-pushed
the
feature/vulkan-upgrade
branch
from
b1204c1 to
860ff24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades Vulkan across macOS, Windows, and Linux to
v1.4.321.0alongide the MoltenVK upgrade tov1.4.0. Some scripts have been updated to use the full version tag, and the Volk step in the setup scripts have been pinned to the correct Vulkan version.The PR has been...
The code has been...
master(according to GitHub)packagetargets