[pure] [lsp] Refactor Pure to make it work with Flèche and recover unit tests #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general it would be nice if future PRs don't remove important tests without fixing them. |
|
@vycastor , I think that some of the refactoring we need for the server should also fix this; in particular the way state is handling needs to be become a bit more abstract as to allow for example file-less parsing. |
ejgallego
force-pushed
the
inline_test+recover
branch
from
26be259 to
368e29a
Compare
Merged
ejgallego
force-pushed
the
inline_test+recover
branch
3 times, most recently
from
b33eb64 to
eceff9a
Compare
ejgallego
force-pushed
the
inline_test+recover
branch
from
eceff9a to
bdbbd9c
Compare
ejgallego
force-pushed
the
inline_test+recover
branch
8 times, most recently
from
20bfa23 to
cbfbd12
Compare
Alidra
changed the title
fblanqui
requested changes
Jul 2, 2025
ejgallego
force-pushed
the
inline_test+recover
branch
from
e12554d to
1fce0ea
Compare
PR Deducteam#289 silently removed important unit tests in the Pure module. We fix this, in particular: - we add parsing offsets to LP's position type (this is very convenient for certain operations. - we add a new parsing API in pure to allow parsing resumption - we add new tests, including parsing resumption. - we fix `Command.equal` as to have equality functions ignore positions. Co-authored-by: Alidra <40537601+Alidra@users.noreply.github.com>
ejgallego
force-pushed
the
inline_test+recover
branch
from
1fce0ea to
94aecf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #289 silently removed important unit tests in the Pure module.
We fix this, in particular:
we add parsing offsets to LP's position type (this is very
convenient for certain operations.
we add a new parsing API in pure to allow parsing resumption
we add new tests, including parsing resumption.
we fix
Command.equalas to have equality functions ignorepositions.