Skip to content

Fix IndexError: pop from empty list #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix IndexError: pop from empty list #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/uhid/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,10 +370,14 @@ def __init__(self, loop: Optional[asyncio.AbstractEventLoop] = None) -> None:
self._loop.add_reader(self._uhid, self._read)

def _async_writer(self) -> None:
self._write(self._write_queue.pop(0))
if not self._write_queue:
self._loop.remove_writer(self._uhid)
self._writer_registered = False
try:
self._write(self._write_queue.pop(0))
except IndexError:
self.__logger.info("writer: queue empty")
finally:
if not self._write_queue:
self._loop.remove_writer(self._uhid)
self._writer_registered = False

def _send_event(self, event: bytes) -> None:
# TODO: benchmark loop.add_writer vs plain write, I feel plain write should be faster in the UHID fd
Expand Down