Skip to content

Conversation

StefanPetersTM
Copy link
Contributor

@StefanPetersTM StefanPetersTM commented Dec 17, 2024

Added a new background preprocessor to estimate the background/ambient noise. This block can be simply added in front of the existing pre-inv-post pipeline

Thank you for submitting a pull request (PR)! Before hitting the submit button, we would be really glad if you check all the following points. Even if you can't check all the boxes below, do not hesitate to go ahead with the PR and ask for help there.

Please also refer to the doc on contributing for more details.

  • Have you run the tests by running pytest from the repository root? See the documentation for more details.
  • Do you follow the code formatting for this project? This can be done by setting up pre-commit hooks as described in the documentation.
  • Is there a unit test for the proposed code modification? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Are there docstrings? Do they follow the numpydoc style?
  • Have you checked that the doc builds properly and that any new RST file has been added to the repo? How to do that is covered in the documentation.
  • Did you document the proposed change(s) in the CHANGELOG file? It should go under "Unreleased".

Happy PR 😃

Added a new background preprocessor to estimate the background/ambient noise. This block can be simply added in front of the existing pre-inv-post pipeline
Added a new background preprocessor to estimate the background/ambient noise. This block can be simply added in front of the existing pre-inv-post pipeline
…to feature/background_estimator

# Conflicts:
#	lensless/utils/dataset.py
…to feature/background_estimator

# Conflicts:
#	lensless/utils/dataset.py
lensless = lensless * color_filter
lensed = lensed * color_filter

# Uncomment to visualize the effect of color shift
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants