Extend dependency chain for dist-rocm+expunge target. #1279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1273.
Technical Details
See the root cause analysis here: #1273 (comment). The dist/rocm directory is populated by each subproject instead of just by one action. Building
dist-rocm+expunge
did not depend onarchive-{NAME}+expunge
targets so thebuild/artifacts/
directories (which are hardlink farms from subproject build directories) were not deleted by building that target.Test Plan
dist-rocm+expunge
dist-rocm
dist/rocm/
directoryTest Result
Submission Checklist