Skip to content

Conversation

marbre
Copy link
Member

@marbre marbre commented Aug 26, 2025

  • Bumps rocm-libraries
    • Rebases and drops 2 patches
    • Adds 3 new patches (2 temporary reverts)
  • Bumps math-libs (hipSOLVER, rocSOLVER) and composable_kernel

This also switches to the new hipBLASLt build-system. Patches haven't been renamed for easier review. A few will be dropped shortly with the next rocm-libraries submodule bump and that chance will be used to renumber the remaining patches.

@marbre marbre force-pushed the users/marbre/bump-20250826-rebase branch from 765eab5 to 2d2d679 Compare August 27, 2025 21:16
@marbre marbre changed the title Bump rocm-libraries submodule 20250826 Bump rocm-libraries submodule 20250828 Aug 28, 2025
@marbre marbre marked this pull request as ready for review August 28, 2025 11:49
@marbre marbre requested review from ScottTodd and davidd-amd August 28, 2025 11:54
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What sort of testing do we want for this? Should we want until we have (working) Windows presubmit coverage?

Or are just the builds enough?

@marbre
Copy link
Member Author

marbre commented Aug 28, 2025

What sort of testing do we want for this? Should we want until we have (working) Windows presubmit coverage?

Or are just the builds enough?

I'd at least like to have a signal on post-submit to see if tests start to dramatically fail. Therefore let's wait with merging until we're in a better spot.

@marbre marbre force-pushed the users/marbre/bump-20250826-rebase branch from 14e89bf to 1e527cc Compare September 2, 2025 09:14
@marbre
Copy link
Member Author

marbre commented Sep 2, 2025

rocBLAS tests failing on windows-strix-halo-gpu-rocm due to missing yaml which is a known issue.

@marbre marbre merged commit 0c9dd6c into main Sep 2, 2025
83 of 87 checks passed
@marbre marbre deleted the users/marbre/bump-20250826-rebase branch September 2, 2025 18:50
@github-project-automation github-project-automation bot moved this from TODO to Done in TheRock Triage Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants