Skip to content

Conversation

andrei-kochin
Copy link

@andrei-kochin andrei-kochin commented Jul 23, 2025

Reason: Deprecation notice

Partly addresses the ROCm/TheRock#1106 in llvm-project

Output remains same:

== Windows Display Drivers
Hostname      :akochin
Advanced Micro Devices, Inc. C:\WINDOWS\System32\DriverStore\FileRepository\u0414593.inf_amd64_f2aefb5d22f93ac9\B413...

@harkgill-amd harkgill-amd added the External Issue reported by community user label Sep 5, 2025
@harkgill-amd
Copy link

Thanks for the heads up on the deprecation and the submission!

The truncation of output with the PowerShell command removes a good chunk of the driver path. Could you set Out-String - Width in the command so that it avoids truncation?

@harkgill-amd harkgill-amd removed the External Issue reported by community user label Sep 8, 2025
@andrei-kochin
Copy link
Author

@harkgill-amd thank you for your comments! applied. Hope that 1000 would be enough for various driver paths

system("powershell -c \"Get-CIMInstance -query 'SELECT * FROM win32_VideoController' | "
"ft AdapterCompatibility,InstalledDisplayDrivers,Name\" | "
"findstr /B /C:\"Advanced Micro Devices\" | "
"Out-String -Width 1000");
Copy link

@harkgill-amd harkgill-amd Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out-String isn't being included in the powershell portion of the command - this'll be interpreted as CMD line and throw an error.

It should be the following

system("powershell -c \"Get-CIMInstance -query 'SELECT * FROM win32_VideoController' | "
       "ft AdapterCompatibility,InstalledDisplayDrivers,Name\ | "
       "Out-String -Width 1000 | findstr /B /C:\'Advanced Micro Devices'\"");

Width of 1000 LGTM.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad misplaced it. Corrected now

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is hipconfig working on your end after these changes? From what I can see,

  • The powershell command is still being closed early due to the " after Name.
  • findstr is not parsing /C:\"Advanced Micro Devices\" correctly.

I'm not entirely sure why the double quotes aren't working correctly despite it being used in the wmic findstr command as well. If you could confirm that hipconfig correctly outputs the driver path, I'm good to approve this. For reference, findstr /B /C:\'Advanced Micro Devices' worked on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants