feat(token-rotation): allow refreshToken to be rotated on every /refresh hit - implements #591 #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't reviewed your changes yet, and I accidentally removed the development branch by mistake :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
This PR introduces a first draft implementation for issue #591.
The proposed feature enables automatic refresh token rotation, which: when enabled, allows clients to maintain continuous access without being forced to re-authenticate, as long as they remain active.
This behavior can significantly improve the user experience, especially for consumer-facing applications.
That said, depending on the sensitivity of the application, this may introduce security trade-offs that should be carefully evaluated.
More details and rationale are discussed in the linked issue.
Feedback and suggestions are welcome!