feat: Non-renderframe-synced keysound/updates #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`timer.update()` is tied to `MainController::render` call, and it is used as a source of truth for keysound & judging system. This patch creates a separate thread that continuously updates the timer. Note that this patch isn't yet tested on the wild or had undergone any unit tests, so it might break some other functionalities. Further testing required.
phu54321
force-pushed
the
feature/fluent_keysound
branch
from
a706941 to
3d41a12
Compare
|
I've used this patch for about a month and hadn't had any issues on mordernchic skin. |
phu54321
commented
Jul 24, 2025
There was a problem hiding this comment.
for anybody wondering why we're also calling timer.update(); on render(), it is possible that the input polling thread somehow magically fails to acquire timerLock for prolonged time. So we want every entity acquiring the timer lock to update the timer ASAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keysound were synced with render frames. The issues are exacerbated on vsync environment or fram-limited situations. This patch tries to mitigate that.
timer.update()is tied toMainController::rendercall, and it is used as a source of truth for keysound & judging system. This patch creates a separate thread that continuously updates the timer.Note that this patch isn't yet tested on the wild or had undergone any unit tests, so it might break some other functionalities. Further testing required.