Skip to content

Portable shared library linking #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Portable shared library linking #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ee3259
Portable shared library linking
breadbored Nov 5, 2021
3fd2f0b
Added SWIFFT_Hash wrapper compatible function
breadbored Nov 6, 2021
d1bcd04
Removed bad code
breadbored Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions cmake/flink.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
include(CMakeParseArguments)

function(target_do_force_link_libraries target visibility lib)
if(MSVC)
target_link_libraries(${target} ${visibility} "/WHOLEARCHIVE:${lib}")
elseif(APPLE)
target_link_libraries(${target} ${visibility} -Wl,-force_load ${lib})
else()
target_link_libraries(${target} ${visibility} -Wl,--whole-archive ${lib} -Wl,--no-whole-archive)
endif()
endfunction()

function(target_force_link_libraries target)
cmake_parse_arguments(FLINK
""
""
"PUBLIC;INTERFACE;PRIVATE"
${ARGN}
)

foreach(lib IN LISTS FLINK_PUBLIC)
target_do_force_link_libraries(${target} PUBLIC ${lib})
endforeach()

foreach(lib IN LISTS FLINK_INTERFACE)
target_do_force_link_libraries(${target} INTERFACE ${lib})
endforeach()

foreach(lib IN LISTS FLINK_PRIVATE)
target_do_force_link_libraries(${target} PRIVATE ${lib})
endforeach()
endfunction()
7 changes: 3 additions & 4 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
include(../cmake/swifft_defaults.cmake)
include(../cmake/flink.cmake)

add_executable(swifft_keygen swifft_keygen.cpp)

Expand Down Expand Up @@ -57,10 +58,8 @@ add_library(swifft_shared SHARED ${CMAKE_CURRENT_BINARY_DIR}/swifft_so_dummy.c)
install(TARGETS swifft_shared DESTINATION lib)
set_target_properties(swifft_shared PROPERTIES OUTPUT_NAME swifft)
set_target_properties(swifft_shared PROPERTIES LINKER_LANGUAGE CXX)
target_link_libraries(swifft_shared PUBLIC
-Wl,--whole-archive
$<TARGET_PROPERTY:swifft_static,NAME>
-Wl,--no-whole-archive
target_force_link_libraries(swifft_shared
PUBLIC $<TARGET_PROPERTY:swifft_static,NAME>
)


Expand Down