-
Notifications
You must be signed in to change notification settings - Fork 79
feat: Add option to disable backup file creation in agents and CLI #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add option to disable backup file creation in agents and CLI #62
Conversation
@FraserKillip thanks for the contribution 🙏 Are you OK to fix the linting errors so that we can land this? |
This if (!agentConfig?.disableBackup) {
await backupFile(output);
} is now repeated so many times across all agents. Surely we can find a way to implement this that only checks once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a --disable-backup
CLI option to prevent creation of .bak
backup files when applying agent configurations, addressing issue #61 by providing users control over backup file generation.
- Adds
disableBackup
parameter throughout the configuration chain from CLI to individual agents - Updates all agent implementations to conditionally skip backup creation when flag is enabled
- Includes comprehensive test coverage for the new functionality across all agent types
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 9 comments.
Show a summary per file
File | Description |
---|---|
src/cli/commands.ts | Adds the --disable-backup CLI option and passes it to the apply function |
src/lib.ts | Propagates the disableBackup flag from CLI to agent configurations |
src/agents/IAgent.ts | Extends the IAgentConfig interface to include the disableBackup option |
src/agents/*.ts | Updates all agent implementations to conditionally skip backup creation |
tests/unit/agents/AgentAdapters.test.ts | Adds comprehensive test coverage for backup disabling functionality |
README.md | Documents the new --disable-backup CLI option with usage examples |
@intellectronica 💯 will get this all tidied up. Might take me a couple days between priorities |
…feature/disable-bak-file-issue-61
a9ceba1
to
80d39e3
Compare
@intellectronica I think this should be ready for re-review when you have the time :ty: |
Solves #61