Skip to content

Add validate_catalogs method for validating single JSON or all JSONs in a directory #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add validate_catalogs method for validating single JSON or all JSONs in a directory #1

wants to merge 2 commits into from

Conversation

matthew-li
Copy link
Collaborator

@matthew-li matthew-li commented Nov 21, 2024 •
edited
Loading

Changes

  • Added a validate_catalogs method that validates a single JSON file, or all JSONs in a directory, returning a list of JSON files and whether they are valid, including any warning and error messages.
    • By default, no more than 10 JSONs are sent to the API within a single request, but this may be configured via a batch_size parameter. (No limit has been set on the API side.)
  • Added tests.

How to Test

  • Review the code changes and add comments as needed.
  • Manual Testing
    • Get an API key and experiment with single catalogs and directories of catalogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthew-li