Skip to content

Conversation

tomas-remis
Copy link

PR description

Implemented Gustafson-Kessel clustering algorithm.

Before

After

  • Added Gustafson-Kessel in genfis.jl
  • Added Gustafson-Kessel unit test in test_genfis.jl
  • Added LinearAlgebra and Statistics packages as project dependencies

Related issues

Checklist

  • Added Gusstafson-Kessel base algorithm
  • Added tests
  • Added docstring
  • Refactored/optimized code
  • Unified Gustafson-Kessel and fuzzy c-means under AbstractFuzzyClustering

Other

@lucaferranti
Copy link
Owner

I think the last item on your todo list would better fit a separate follow-up PR


[compat]
Aqua = "0.6"
Dictionaries = "0.3"
DocStringExtensions = "0.9"
LightXML = "0.9"
LinearAlgebra = "1.11.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LinearAlgebra = "1.11.0"
LinearAlgebra = "1.6"

since we want the library to work also on older julia versions (starting to 1.6) we want to set the lower bound to 1.6, similar for Statistics

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I think you'll need ]add Random and add a lower bound (also 1.6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants