fix: use proper linter config and fix errors #7278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
approved these changes
Sep 1, 2025
Comment on lines
+110
to
+130
| // Allow all when no search text (NcSelect already restricts remote query) | ||
| if (!search) { | ||
| return true | ||
| } | ||
| const term = search.toLowerCase() | ||
| // Match against provided label, email, or user identifier | ||
| return (label && label.toLowerCase().includes(term)) | ||
| || (option.email && option.email.toLowerCase().includes(term)) | ||
| || (option.user && option.user.toLowerCase().includes(term)) |
There was a problem hiding this comment.
I wasn't sure if I can remove it, and it just returned true every time.
So I made it actually do something LOL
Search is working
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/linter-and-errors
branch
from
ad6fefa to
11fc845
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7278 +/- ##
=======================================
Coverage 14.84% 14.84%
=======================================
Files 212 212
Lines 10299 10297 -2
Branches 2484 2474 -10
=======================================
Hits 1529 1529
+ Misses 8420 8418 -2
Partials 350 350
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors
