Skip to content

Conversation

bergmeister
Copy link
Contributor

@bergmeister bergmeister commented Dec 13, 2018

Run build/test script and upload test results in AppVeyor. Just add this repo to AppVeyor and it will work out of the box. Here is a build from my fork.

The build that uses Windows PowerShell here exhibits a bug in Assert btw:
image

@nohwnd
Copy link
Owner

nohwnd commented Dec 14, 2018

Thanks, I am already building against some Linux on Travis. Is there any benefit in having two builds that target Linux?

The message is not a bug, it's a warning that if seen by an end-user should be reported because then it means that Options are not passed correctly in recursive calls, but in the build it is normal because I am not providing the options in many tests. A solution to that would be making the Option parameter mandatory and give options to all tests, but I did not want to do that (yet?).

@nohwnd
Copy link
Owner

nohwnd commented Dec 14, 2018

One more question, is it possible to run against PowerShell 3 & 4 on AppVeyor as well?

@bergmeister
Copy link
Contributor Author

Well, before the build definition was not part of source control and was only testing against ps5.1
Now we also test against v6 on Linux and Windows.
Appveyor has a legacy WMF4 that one can request, I could help you with that.

@nohwnd
Copy link
Owner

nohwnd commented Dec 14, 2018

The build definition for travis is in the source control for a long time, even your PR is built against linux and macos. I don't think it's worth to build it twice on two different linux versions distros.

image

The wmf4 would be great, how do I request it? I would actually like to set this up for Pester as well, the community build server is very slow so I would move to travis+appveyor and the rest could run on azurepipelines where I can also sign and release, but I want to leverage the community provided infrastructure as much as possible :)

@bergmeister
Copy link
Contributor Author

bergmeister commented Dec 14, 2018

No, I was saying that appveyor.yml should be in source control so that people can run the build in their forks as well and see what it is doing, I could eliminate the Linux element if you want to in the matrix so that it only runs against PowerShell 5.1 and 6.1 on Windows if you do not want to run against Linux twice.

@bergmeister
Copy link
Contributor Author

@IlyaFinkelshteyn Could you please enable the WMF3 and WMF4 legacy images for this repo?

@nohwnd
Copy link
Owner

nohwnd commented Dec 14, 2018

@bergmeister Now I understand. :) Yes please remove the ubuntu from the config.

@nohwnd nohwnd merged commit 670a9b7 into nohwnd:master Dec 14, 2018
@IlyaFinkelshteyn
Copy link

@bergmeister Enabled WMF4. We do not have WMF3 though.

@nohwnd
Copy link
Owner

nohwnd commented Dec 18, 2018

@IlyaFinkelshteyn thank you. Could you enable it for https://github.com/pester/Pester as well please?

@bergmeister
Copy link
Contributor Author

bergmeister commented Dec 18, 2018

@IlyaFinkelshteyn Thanks. I tried using the WMF4 image in this new PR but it does not seem to work

@IlyaFinkelshteyn
Copy link

@bergmeister I think it is because we both confused and actual image name is WMF 4, not WMF4 :) Can you please try with a space?

@nohwnd GitHub project https://github.com/pester/Pester is being build with the same AppVeyor account, e.g. nohwnd. It least this is what I see when I open commit status. For this AppVeyor account WMF 4 image is already enabled.

Please let me know how it goes.

@nohwnd
Copy link
Owner

nohwnd commented Dec 18, 2018

@IlyaFinkelshteyn thanks!

@bergmeister
Copy link
Contributor Author

@IlyaFinkelshteyn Thanks, sorry, I forgot about the space in the name. Yes, it works now, it is just the code now that needs adaption to work with that PowerShell version :)

@IlyaFinkelshteyn
Copy link

@bergmeister great, thank for the update!

@bergmeister bergmeister deleted the appveyor branch December 18, 2018 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants