feature: add generic device named as utility #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwandor
reviewed
Jul 10, 2025
There was a problem hiding this comment.
Rather than adding a generic driver like this, which has assumptions such as only having one virtqueue, how would you feel about making VirtQueue and any other types which you need for your driver public, so that you can implement the driver outside of this crate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a possible demonstration of the effect. The purpose of implementing this interface is to expose sufficient low-level space to developers, in order to avoid code duplication and waste. The main examples are 9p and customized virtio devices.
For simplicity, it assume here that there is only one virtio queue. Of course, I think the naming of "utility" still has room for discussion. And it is also likely that there are more elegant implementation methods.
Some test cases may need to be added, if this design is determined to be necessary.
Related to #201.