Skip to content

Conversation

4JX
Copy link

@4JX 4JX commented Sep 6, 2025

Otherwise it keeps creating oldDir's child folders inside themselves until the path is too long for the OS to handle.

May just have lost about a year's worth of notes to this. Oh well, lesson learned, backup things more throughoutly.

Note: I am really against the delete over at

await moveDirContents(oldDir: oldDir, newDir: newDir);
await oldDir.delete(recursive: true);

Existing because it is a ticking timebomb waiting to delete an user's files if they "Allow access" to the wrong folder. The least that should be done is have a checkbox to optionally delete the old stuff with the user's consent. May be able to get worked into this PR, lmk your thoughts.

Copy link

codecov bot commented Sep 6, 2025

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.58%. Comparing base (0580e1f) to head (fe70104).

Files with missing lines Patch % Lines
lib/data/file_manager/file_manager.dart 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1519      +/-   ##
==========================================
- Coverage   48.61%   48.58%   -0.04%     
==========================================
  Files         125      125              
  Lines        8975     8981       +6     
==========================================
  Hits         4363     4363              
- Misses       4612     4618       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Otherwise it keeps creating oldDir's child folders inside themselves indefinitely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant