Skip to content

Fix generated tables when using bootstrap3 template #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix generated tables when using bootstrap3 template #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions syntax/table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,19 @@ function preList($clist, $data) {
'</div>';
$text .= '</div>';
}

// fixes for bootstrap tpl
if( isset($conf['tpl']['bootstrap3']['tableStyle'])) {
$ts = explode(',', $conf['tpl']['bootstrap3']['tableStyle']);
foreach ($ts as $class) {
if ($class == 'responsive') {
$text = str_replace('<div class="table', '<div class="table table-responsive', $text);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding this as if at line 370? Than the str_replace() is not needed, it is?
And further, is a tpl specific solution here the best?

} else {
$data['classes'] .= " table-$class";
}
}
}

// build table
$text .= '<table class="inline dataplugin_table ' . $data['classes'] . '">';
// build column headers
Expand Down