proxy: release CI #3634
proxy: release CI #3634
Conversation
chirag-parmar
force-pushed
the
proxy-release
branch
from
5e04363 to
d99a747
Compare
| shasum -a 512 build/nimbus_verified_proxy > "nimbus_verified_proxy.sha512sum" | ||
| - name: Upload release binary artifacts | ||
| if: success() && startsWith(github.ref, 'refs/tags/') | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: proxy-${{ matrix.os }}-${{ matrix.cpu }} | ||
| path: | | ||
| build/nimbus_verified_proxy* | ||
| if-no-files-found: warn | ||
|
|
||
| - name: Upload release checksum artifacts | ||
| if: success() && startsWith(github.ref, 'refs/tags/') | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: proxy-${{ matrix.os }}-${{ matrix.cpu }}-checksum | ||
| path: | | ||
| build/nimbus_verified_proxy.sha512sum | ||
| if-no-files-found: warn |
There was a problem hiding this comment.
this means the release will misbehave when the current verified proxy CI hasn't finished it's build?
i.e release might use stale artifacts
There was a problem hiding this comment.
Ah right, I just realised github workflows are not pipelined. Should I go ahead and pipeline the workflows or should I just rebuild the verified proxy for the release job(rebuilding seems wasteful)?
There was a problem hiding this comment.
Ah right, I just realised github workflows are not pipelined. Should I go ahead and pipeline the workflows or should I just rebuild the verified proxy for the release job(rebuilding seems wasteful)?
Whatever gets selected here, please also think ahead in the sense that nimbus_portal_client will also need to be added to the release binaries eventually
| @@ -133,9 +133,22 @@ jobs: | |||
| cat linux-arm64-checksum/* >> release_notes.md | |||
| echo '# Windows AMD64' >> release_notes.md | |||
| cat windows-amd64-checksum/* >> release_notes.md | |||
| echo '# macos ARM64' >> release_notes.md | |||
| echo '# MacOS ARM64' >> release_notes.md | |||
There was a problem hiding this comment.
Official capitalization is macOS
| cat proxy-linux-arm64-checksum/* >> release_notes.md | ||
| echo '# Windows AMD64' >> release_notes.md | ||
| cat proxy-windows-amd64-checksum/* >> release_notes.md | ||
| echo '# MacOS ARM64' >> release_notes.md |
|
The expected correct way would to implement the VP distribution build into This currently generates EL build, but should also generate a VP build |
No description provided.