Skip to content

Add PreUp/PostUp/PreDown/PostDown to env variables for server.conf cr… #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add PreUp/PostUp/PreDown/PostDown to env variables for server.conf cr… #209

wants to merge 1 commit into from

Conversation

DarwinsBuddy
Copy link

@DarwinsBuddy DarwinsBuddy commented Sep 19, 2021 •
edited
Loading

Hope this helps

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sidewaysglance
sidewaysglance approved these changes Oct 14, 2021
View reviewed changes
Copy link

@sidewaysglance sidewaysglance left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any problems with this - seems like a long awaited feature. Should be good to go.

@sidewaysglance
Copy link

sidewaysglance commented Oct 25, 2021 •
edited
Loading

What is the consensus on this?

It changes the manual instantiation of the wg adapter so that it uses wg-quick instead of ip link add - I don't know if there's any issues with using this approach.

From my point of view, the subspacecommunity/subspace package can only replace a manual wg config if these actions are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@4nner 4nner 4nner approved these changes

@sidewaysglance sidewaysglance sidewaysglance approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarwinsBuddy @sidewaysglance @4nner