Skip to content

Reduce the granularity of the lock #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce the granularity of the lock #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 23 additions & 25 deletions include/cache.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,25 +75,26 @@ class fixed_sized_cache
*/
void Put(const Key &key, const Value &value) noexcept
{
operation_guard lock{safe_op};
auto elem_it = FindElem(key);

if (elem_it == cache_items_map.end())

{
// add new element to the cache
if (cache_items_map.size() + 1 > max_cache_size)
operation_guard lock{safe_op};
if (elem_it == cache_items_map.end())
{
auto disp_candidate_key = cache_policy.ReplCandidate();

Erase(disp_candidate_key);
// add new element to the cache
if (cache_items_map.size() + 1 > max_cache_size)
{
auto disp_candidate_key = cache_policy.ReplCandidate();
Erase(disp_candidate_key);
}

Insert(key, std::move(value));
}
else
{
// update previous value
Update(key, std::move(value));
}

Insert(key, value);
}
else
{
// update previous value
Update(key, value);
}
}

Expand Down Expand Up @@ -168,18 +169,15 @@ class fixed_sized_cache
*/
bool Remove(const Key &key)
{
operation_guard lock{safe_op};

auto elem = FindElem(key);

if (elem == cache_items_map.end())
auto elem_it = FindElem(key);

if (elem_it != cache_items_map.end())
{
return false;
operation_guard lock{safe_op};
Erase(elem_it);
return true;
}

Erase(elem);

return true;
return false;
}

protected:
Expand Down