-
-
Notifications
You must be signed in to change notification settings - Fork 258
Open
Labels
bugSomething isn't workingSomething isn't working
Description
On line
docker-mastery-for-nodejs/sample-buildkit/Dockerfile
Lines 49 to 56 in 43ffcab
## Stage 4 (testing) | |
# use this in automated CI | |
# it has prod and dev npm dependencies | |
# In 18.09 or older builder, this will always run | |
# In BuildKit, this will be skipped by default | |
FROM interm as test | |
CMD ["npm", "test"] |
There are two ways to fix that:
-
Use
COPY --from=dev /opt/node_modules/ /opt/node_modules/
in test stage to combine the node modules. -
Have dev stage install all npm dependencies (remove
--only=development
) and then change the test stage toFROM dev
as @ivorscott suggested (I like this the most).
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Projects
Status
Broken/Degraded Lecture 😥