-
Notifications
You must be signed in to change notification settings - Fork 453
fix(segment-update): handle rules/conditons without id correctly #5953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5953 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 1275 1275
Lines 45227 45267 +40
=======================================
+ Hits 44261 44301 +40
Misses 966 966 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Sorry, couple of comments. Being a bit annoying just to close the topic once and for all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Overwrite the
__init__
method to handle deletion of rules/conditions correctly. The earlier implementation was overriding get_initial, but sinceWritableNestedModelSerializer
uses that internally, it resulted in some strange behavior where rules/conditions that should have been created or updated were instead removed.How did you test this code
Adds unit tests