Skip to content

Conversation

Guiners
Copy link
Contributor

@Guiners Guiners commented Aug 22, 2025

Description

Add a new GenAI Vertex AI Search tool sample.

  • Test is running locally fine.

  • To make this test work locally for me and my project, I use:
    const DATASTORE =
    'projects/cloud-ai-devrel-softserve/locations/global/collections/default_collection/dataStores/example-adk-website-datastore_1755611010401';
    from file tools-vais-with-txt.

  • To make the test look and work the same as in the Python sample, it is used:
    const datastore = projects/${projectId}/locations/global/collections/default_collection/dataStores/grounding-test-datastore;
    from tools-vais-with-txt.test.

IMO, the project that is used to run the test is missing a resource from above. Adding it should fix it.

  • To make the Vertex AI Search tool with text sample work locally, a datastore had to be created, and the Discovery Engine Editor role was required. This means the pipeline will fail without them.
  • For reference, for this test, I used the same datastore that is used in the corresponding Python sample: projects/{PROJECT_ID}/locations/global/collections/default_collection/dataStores/grounding-test-datastore

Checklist

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 22, 2025
@Guiners Guiners changed the title feat(genai): tools vias sample feat(genai): tools vais sample Aug 22, 2025
@Guiners Guiners marked this pull request as ready for review August 25, 2025 07:53
@Guiners Guiners requested review from a team as code owners August 25, 2025 07:53
Copy link

snippet-bot bot commented Aug 25, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants