🧹 code organization and dead code elimination #971

johnnychen94 · 2021-08-03T12:34:14Z

By setting compatibility to ImageCore 0.9 only, there are a lot of legacy codes and compat patches being unnecessary now. This PR aims to clean the codebase.

TODO:

decide which deprecations need to be Base.depwarn(...; force=true)

closes #974
closes #976

codecov · 2021-08-03T12:39:51Z

Codecov Report

Merging #971 (972d810) into master (9796acc) will increase coverage by 0.98%.
The diff coverage is 78.68%.

@@            Coverage Diff             @@
##           master     #971      +/-   ##
==========================================
+ Coverage   86.73%   87.72%   +0.98%     
==========================================
  Files           9        8       -1     
  Lines        1101      823     -278     
==========================================
- Hits          955      722     -233     
+ Misses        146      101      -45

Impacted Files	Coverage Δ
src/Images.jl	`100.00% <ø> (+100.00%)`	⬆️
src/corner.jl	`88.40% <0.00%> (ø)`
src/edge.jl	`84.51% <40.00%> (ø)`
src/deprecations.jl	`87.08% <81.25%> (-0.77%)`	⬇️
src/algorithms.jl	`92.00% <100.00%> (+5.52%)`	⬆️
src/compat.jl	`50.00% <100.00%> (ø)`
src/labeledarrays.jl	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9796acc...972d810. Read the comment docs.

timholy · 2021-08-28T20:30:49Z

It's quite satisfying to rip out large hunks of legacy code...thanks for starting this effort!

johnnychen94 · 2021-09-01T13:11:44Z

This is the complement to `varmult`. Useful for finishing JuliaImages/Images.jl#971

timholy · 2021-09-06T20:20:33Z

The var/std fix relies on JuliaGraphics/ColorVectorSpace.jl#175

johnnychen94 · 2021-09-07T01:33:51Z

I won't be available this week. I'll work on the imgaussiannoise , imROF and *_threshold for the next two weeks. For entropy, if we decide to move to ImageQualityIndexes, then we can do it like colorfulness so that we can allow a few more entropy implementations with shannon the default.

timholy · 2021-09-07T07:13:53Z

No rush. I think it will be better to wait for you and do the whole thing before making the next release. But if you disagree, I can get this stuff finished and make a 0.25 release, and then we can do the rest in 0.26.

This came from Images.jl and is part of the code clean-out making Images.jl mostly a "meta-package." It's also better to put glue functionality in one of the packages that defines the components, since that ensures that the glue-code is always available whenever the operation can be supported. xref JuliaImages/Images.jl#971

This came from Images.jl and is part of the code clean-out making Images.jl mostly a "meta-package." It's also better to put glue functionality in one of the packages that defines the components, since that ensures that the glue-code is always available whenever the operation can be supported. xref JuliaImages/Images.jl#971 This also deletes a schedule CI run, which risks disabling CI if activity is low.

timholy · 2021-09-09T21:33:17Z

OK, I think I've done all the ones you haven't carved out for yourself. I'm leaving div for you because it really seems to be part of imROF.

This is the complement to `varmult`. Useful for finishing JuliaImages/Images.jl#971

johnnychen94 · 2021-09-10T03:32:42Z

For test_approx_eq_sigma_eps, there are two possible places to host it with enhancements: 1) https://github.com/JuliaPlots/VisualRegressionTests.jl already has a duplication so I believe people there would like to help maintain it, 2) separate https://github.com/JuliaTesting/ReferenceTests.jl into core package and image-specific packages so that we can add ImageFiltering dependency.

timholy · 2021-09-10T09:21:58Z

I'd be fine with either. We could also put it in ImageFiltering I guess?

timholy · 2021-09-10T09:34:31Z

OK if I rebase this? It turns out #927 had a breakage. But if you have local changes I don't want to make it harder for you.

johnnychen94 · 2021-09-10T11:55:33Z

Sure feel free to rebase

timholy · 2021-10-12T10:30:47Z

BTW, I know you are super-busy, so if you want to leave some of those items for later, that's fine. We could release a 0.25 and finish the rest in 0.26. Just wanted to let you know that it's not a contract!

johnnychen94 · 2021-10-12T10:39:37Z

I wanna make sure that we get a stable ImageBase version, introduce it to Images.jl, and then immediately deprecate their old versions. Otherwise, we would need some extra efforts to maintain the possible conflicts and compatibilities.

I'm working on ROF now, let me see if I can finish this this weekend, will this be okay?

timholy · 2021-10-12T11:05:28Z

Absolutely! I'm not in a rush, it's just that if it were to be, say, another couple months then maybe we'd want to think about an intermediate solution.

johnnychen94 · 2021-11-03T00:41:38Z

This is a long journey, finally, we're so close. Every commit is carefully checked to be clean so that if we get into trouble we can quickly identify the issues.

There are still some unchecked items in the todo-list but that doesn't block the new release. I thought we can get rid of the entire algorithm.jl file but turns out it takes more effort than I thought to modernize all the functions 😄

@timholy After this PR is merged we then need to update NEWS.md and the module docstring #982. I'll do this in the next few days.

This commit introduces a new package IntegralArrays

This commit also removes old versions of ImageIO and ImageMagick from compat list. fixup

This requires ImageMorphology at least v0.3

From #927

This commit removes a lot of duplicated and lengthy import/export lines so that we can focus on a more high-level management of this umbrella package. This requires at least Reexport v1.1 to work

This version removes two deprecated symbols: `ssim` and `psnr`. This version also reimplemented the entropy function using ImageContrastAdjustment so that the function works on generic images.

- `accum` is removed - `graytype` is made an internal trait

timholy · 2021-11-03T08:00:56Z

Thanks for all your efforts here. It is a ton of work, but the outcome feels like a major leap forward. 1.0 is starting to seem within sight...

johnnychen94 · 2021-11-05T16:16:13Z

If there's no plan to review this PR then I think we can merge it and prepare for the v0.25 release.

This came from Images.jl and is part of the code clean-out making Images.jl mostly a "meta-package." It's also better to put glue functionality in one of the packages that defines the components, since that ensures that the glue-code is always available whenever the operation can be supported. xref JuliaImages/Images.jl#971 This also deletes a schedule CI run, which risks disabling CI if activity is low.

johnnychen94 changed the title ~~🧹 legacy code organization and elimination~~ 🧹 code organization and dead code elimination Aug 3, 2021

johnnychen94 mentioned this pull request Aug 20, 2021

Drop ImageCore 0.8, ColorVectorSpace 0.8, and Colors 0.9 compatibility #972

Closed

10 tasks

timholy mentioned this pull request Aug 28, 2021

Move *finite statistics functions from Images JuliaImages/ImageBase.jl#13

Merged

johnnychen94 force-pushed the jc/houseclean branch from 9007b77 to bad872f Compare August 28, 2021 21:30

johnnychen94 mentioned this pull request Sep 1, 2021

Move extremization, blob_LoG from Images JuliaImages/ImageFiltering.jl#223

Merged

timholy mentioned this pull request Sep 4, 2021

Add box and laplacian2d JuliaImages/ImageFiltering.jl#226

Merged

johnnychen94 mentioned this pull request Sep 6, 2021

JuliaImages 1.0 and beyond — a two year roadmap #977

Open

9 tasks

timholy added a commit to JuliaGraphics/ColorVectorSpace.jl that referenced this pull request Sep 6, 2021

Add stdmult

15481fc

This is the complement to `varmult`. Useful for finishing JuliaImages/Images.jl#971

timholy mentioned this pull request Sep 6, 2021

Add stdmult JuliaGraphics/ColorVectorSpace.jl#175

Merged

timholy mentioned this pull request Sep 9, 2021

Transfer support for ImageMeta JuliaImages/ImageMorphology.jl#44

Merged

timholy added a commit to JuliaGraphics/ColorVectorSpace.jl that referenced this pull request Sep 9, 2021

Add stdmult (#175)

56fa176

This is the complement to `varmult`. Useful for finishing JuliaImages/Images.jl#971

timholy force-pushed the jc/houseclean branch from e8a2118 to 5876d29 Compare September 10, 2021 12:04

johnnychen94 mentioned this pull request Sep 25, 2021

move integral_image to ImageBase JuliaImages/ImageBase.jl#10

Closed

johnnychen94 mentioned this pull request Oct 11, 2021

WIP: add lazy finite difference DiffView and fdiv JuliaImages/ImageBase.jl#19

Closed

johnnychen94 force-pushed the jc/houseclean branch 2 times, most recently from 0ab55b8 to 8bff142 Compare November 3, 2021 00:23

johnnychen94 enabled auto-merge November 3, 2021 00:27

timholy and others added 12 commits November 3, 2021 08:49

🧹 Deprecate var/std in favor of varmult/stdmult

4516b5b

🧹 Deprecate integral_image/boxdiff in favor of IntegralArrays

d8e5d3d

This commit introduces a new package IntegralArrays

🧹 Deprecate imaverage and imlaplacian in favor of ImageFiltering

3b9feda

set Julia compatibility to at least 1.3

075172f

This commit also removes old versions of ImageIO and ImageMagick from compat list. fixup

🧹 Move erode/dilate for ImageMetadata to ImageMorphology

fcdca59

This requires ImageMorphology at least v0.3

🐛 Fix broken depwarn & whitespace for ColorizedArray

65931ce

From #927

🧹 remove duplicated reexport symbols and lengthy Base imports

d876c14

This commit removes a lot of duplicated and lengthy import/export lines so that we can focus on a more high-level management of this umbrella package. This requires at least Reexport v1.1 to work

🧹 Don't directly depend on OffsetArrays

e1dd70c

🧹 use ImageCore.NumberLike

e3d5d9a

bump compat for IndirectArrays to 1, (keep existing compat)

32f84a3

set ImageQualityIndexes compatibility to at least v0.3

8730a3d

This version removes two deprecated symbols: `ssim` and `psnr`. This version also reimplemented the entropy function using ImageContrastAdjustment so that the function works on generic images.

🧹 remove unused traits

972d810

- `accum` is removed - `graytype` is made an internal trait

johnnychen94 force-pushed the jc/houseclean branch from 8bff142 to 972d810 Compare November 3, 2021 00:50

This was referenced Nov 4, 2021

various package status improvement peterkovesi/ImagePhaseCongruency.jl#8

Merged

rewrite the module docstring #985

Merged

johnnychen94 mentioned this pull request Nov 24, 2021

prune_segments - ERROR: MethodError: no method matching add_vertices!(::SimpleWeightedGraph{Int64, Float64}, ::Int64) JuliaImages/ImageSegmentation.jl#86

Closed

johnnychen94 disabled auto-merge November 24, 2021 15:52

johnnychen94 enabled auto-merge November 24, 2021 15:52

johnnychen94 disabled auto-merge November 24, 2021 15:52

johnnychen94 merged commit feb7a00 into master Nov 24, 2021

johnnychen94 deleted the jc/houseclean branch November 24, 2021 15:53

🧹 code organization and dead code elimination #971

🧹 code organization and dead code elimination #971

Uh oh!

Conversation

johnnychen94 commented Aug 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

timholy commented Aug 28, 2021

Uh oh!

johnnychen94 commented Sep 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timholy commented Sep 6, 2021

Uh oh!

johnnychen94 commented Sep 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timholy commented Sep 7, 2021

Uh oh!

timholy commented Sep 9, 2021

Uh oh!

johnnychen94 commented Sep 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timholy commented Sep 10, 2021

Uh oh!

timholy commented Sep 10, 2021

Uh oh!

johnnychen94 commented Sep 10, 2021

Uh oh!

timholy commented Oct 12, 2021

Uh oh!

johnnychen94 commented Oct 12, 2021

Uh oh!

timholy commented Oct 12, 2021

Uh oh!

johnnychen94 commented Nov 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timholy commented Nov 3, 2021

Uh oh!

johnnychen94 commented Nov 5, 2021

Uh oh!

Uh oh!

johnnychen94 commented Aug 3, 2021 •

edited

Loading

codecov bot commented Aug 3, 2021 •

edited

Loading

johnnychen94 commented Sep 1, 2021 •

edited

Loading

johnnychen94 commented Sep 7, 2021 •

edited

Loading

johnnychen94 commented Sep 10, 2021 •

edited

Loading

johnnychen94 commented Nov 3, 2021 •

edited

Loading