-
Notifications
You must be signed in to change notification settings - Fork 15
drop ImageInTerminal
#117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop ImageInTerminal
#117
Conversation
This PR would be much better if it was broken into two. |
Agreed, will split (EDIT: see #118). |
Maybe we'd just switch to |
This is very clever and benefits from the rework / splitting of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we'd need to release JuliaImages/XTermColors.jl#8 (review) first
@t-bltg let me know when you're ready for ReferenceTests v0.10 release. |
When you want, so that we can go forward on JuliaImages/ImageInTerminal.jl#71. |
Fix #116, all tests pass locally.
Needs JuliaImages/ImageInTerminal.jl#71 and JuliaImages/XTermColors.jl#8.
Ping @johnnychen94 for review, since I cannot request for a review here (not a member of
JuliaTesting
org).