Fixes #37816 - List view_smart_proxies as valid permission for non admin user

[chris1984]

What are the changes introduced in this pull request?

• When trying to query smart proxies with curl or hammer on a user that is not an admin, the view_smart_proxies permission is needed from Foreman, we did not have this before and would only list Katello permissions. We hard code view_smart_proxies here when getting the proxies from Foreman

  katello/app/controllers/katello/api/v2/capsules_controller.rb

  Line 13 in 746bda7

  @smart_proxies = SmartProxy.with_content.authorized(:view_smart_proxies).includes(:features).

{"message":"Access denied","details":"Missing one of the required permissions: manage_capsule_content","missing_permissions":["manage_capsule_content"]}
}

Considerations taken when implementing this change?

• Make sure you can still see Smart Proxies

What are the testing steps for this pull request?

• Create a user with a role that only has view_capsule_content and manage_capsule_content
• Try to curl and see the error message curl -k -u unauth:unauth https://localhost/katello/api/capsules/
• Apply PR
• Try the curl again and see if it shows the missing view_smart_proxies permission
• Apply the permission and see if curl completes without an error

[vsedmik]

Works good:

$ curl -k -u unauth:unauth https://satellite.redhat.com/katello/api/capsules/
{
  "error": {"message":"Access denied","details":"Missing one of the required permissions: view_smart_proxy, manage_capsule_content, view_capsule_content","missing_permissions":["view_smart_proxy","manage_capsule_content","view_capsule_content"]}
}
$ curl -k -u unauth:unauth https://satellite.redhat.com/katello/api/capsules/2
{
  "error": {"message":"Access denied","details":"Missing one of the required permissions: view_smart_proxy, manage_capsule_content, view_capsule_content","missing_permissions":["view_smart_proxy","manage_capsule_content","view_capsule_content"]}
}

(unauth is an user with insufficient permissions)

[vsedmik]

Should we go plural?

[vsedmik]

Looks we are good now. Thanks for the patch!

[sjha4]

Ack.. 🎉