Fixes #37886 - CV index page doesn't accurately reflect needs_publish #11171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Move needs_publish attribute to base json rabl so index page has access to it along with details page.
The CV index page today doesn't have this attribute and hence always assumes it's false and always shows the No updates banner on publish wizard regardless of state of CV.
Considerations taken when implementing this change?
There are performance impacts of having the needs_publish attribute on CV index response cause this value is not indexed, rather calculated per CV. So it adds a performance hit when pagination size is big. We need to ensure this is an accepatable hit.
The other fix could be to add a CV details API call when publish wizard is opened from the index page and I am debating whether to go down that route depending on how people feel about it.
What are the testing steps for this pull request?