Fix MQTT-C issue with TLS 1.3 session tickets #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TLS 1.3 server may choose to issue new session ticket in the middle of active connection. This will cause next mbedtls_ssl_read() or mbedtls_ssl_write() to return MBEDTLS_ERR_SSL_RECEIVED_NEW_SESSION_TICKET. This is not a real error, rather notification to the application to save session ticket for later use. As TLS reconnection is out of scope at this point we can safely ignore it and retry operation. Please refer to mbedtls/programs/ssl/ssl_client2.c for session ticket handling. Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
|
Ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS 1.3 server may choose to issue new session ticket in the middle of active connection. This will cause next mbedtls_ssl_read() or mbedtls_ssl_write() to return MBEDTLS_ERR_SSL_RECEIVED_NEW_SESSION_TICKET. This is not a real error, rather notification to the application to save session ticket for later use. As TLS reconnection is out of scope at this point we can safely ignore it and retry operation.
Please refer to mbedtls/programs/ssl/ssl_client2.c for session ticket handling.