refactor!: update to boilerplate mapco 6313 #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o refactor/update-to-boilerplate-mapco-6313
…ithub.com/MapColonies/geocoding into refactor/update-to-boilerplate-mapco-6313
NivGreenstein
requested changes
Aug 7, 2025
package.json
Outdated
| "@map-colonies/js-logger": "^2.0.0", | ||
| "@map-colonies/openapi-express-viewer": "^4.0.0", | ||
| "@map-colonies/read-pkg": "^1.0.0", | ||
| "@map-colonies/schemas": "https://ghatmpstorage.blob.core.windows.net/npm-packages/schemas-5cee47beaa951abaf352f9ffd6895689521e9829.tgz", |
There was a problem hiding this comment.
Remember to change before merging
NivGreenstein
requested changes
Aug 12, 2025
src/common/redis/index.ts
Outdated
| const config = container.resolve<IConfig>(SERVICES.CONFIG); | ||
| const dbConfig = config.get<RedisConfig>('db.redis'); | ||
| const config = container.resolve<ConfigType>(SERVICES.CONFIG); | ||
| const dbConfig = config.get(redisConfigPath) as RedisConfig; |
| @@ -35,6 +35,7 @@ export class TileManager { | |||
| let bbox: BBox = [0, 0, 0, 0]; | |||
| try { | |||
| bbox = mgrs.inverse(tileQueryParams.mgrs); | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| } catch (error) { | |||
There was a problem hiding this comment.
Remove this and add log
| @@ -115,7 +121,7 @@ describe('/search/location', function () { | |||
| limit: 5, | |||
| disable_fuzziness: true, | |||
| }; | |||
| const tokenTypesUrlScope = nock(config.get<IApplication>('application').services.tokenTypesUrl) | |||
| const tokenTypesUrlScope = nock((config.get('application') as IApplication).services.tokenTypesUrl) | |||
There was a problem hiding this comment.
Remove the config.get as ... SomeInterface here and all other places
…ithub.com/MapColonies/geocoding into refactor/update-to-boilerplate-mapco-6313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: MAPCO-6131
Closes: MAPCO-6131