Fix the error message selection condition #3037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous condition was basically "if this is non-nullish or a boolean". That "or a boolean" is very obviously redundant. In reality, the intent is it's supposed to be detecting holes.
I have no idea how I missed this mistake when I first wrote this.
Motivation and Context
See above.
How Has This Been Tested?
Untested locally, but it's a simple and obvious enough fix that I'm fine just letting CI test it. If tests somehow fail, I can patch the broken tests accordingly.
Types of changes
Checklist