Skip to content

Conversation

fingolfin
Copy link
Member

Relanding PR #2092 (see also #2128 and #2130). Needs oscar-system/Oscar.jl#5153

@fingolfin fingolfin added enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Jul 23, 2025
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.15%. Comparing base (02ad3a9) to head (0e64438).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/Fraction.jl 55.55% 4 Missing ⚠️
src/generic/RationalFunctionField.jl 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2132      +/-   ##
==========================================
+ Coverage   87.98%   88.15%   +0.17%     
==========================================
  Files         126      126              
  Lines       31665    32355     +690     
==========================================
+ Hits        27860    28524     +664     
- Misses       3805     3831      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lgoettgens
Copy link
Member

Added a breaking label since this needs downstream changes in form of oscar-system/Oscar.jl#5153

@fingolfin fingolfin closed this Aug 25, 2025
@fingolfin fingolfin reopened this Aug 25, 2025
@fingolfin
Copy link
Member Author

Re-running CI now. Assuming this passes, I hope we can include it in the next breaking release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants