Fix building and linking with GCC 10 #775
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyn_ring_queue.h defines 2 global variables that are used in many source files. This patch makes those variables ( C2G_InQ, C2G_OutQ ) external in the header, and intiates them in dyn_ring_queue.c
|
This fix helps me when building the Dynomite (Multiple definition errors both variables) on alpine Linux (ARM64 and AMD64). |
|
Wonderful, thank you! This also resolves the build on RHEL 9, GCC 11. |
mcouillard
added a commit
to vtinfo/dynomite
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dyn_ring_queue.h defines 2 global variables that are used in many
source files. This patch makes those variables ( C2G_InQ, C2G_OutQ )
external in the header, and intiates them in dyn_ring_queue.c