Allow open redirect for Rails 7.0 in #redirect_back_or_to method #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berkos
changed the title
willnet
reviewed
Mar 27, 2024
Comment on lines
100
to
+101
| def redirect_back_or_to(url, flash_hash = {}) | ||
| redirect_to(session[:return_to_url] || url, flash: flash_hash) | ||
| redirect_to(session[:return_to_url] || url, flash: flash_hash, allow_other_host: true) |
There was a problem hiding this comment.
The redirect_back_or_to method, unlike what's described in #318, might accept user input depending on how it's used. Therefore, it would be more secure and preferable to not set allow_other_host to true by default, but rather, to provide it as an argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Thanks for the review in advance.
Fixes open redirect for Rails 7.0
https://api.rubyonrails.org/classes/ActionController/Redirecting.html#method-i-redirect_to-label-Open+Redirect+protection
The PR here follows a similar approach with #318
Please ensure your pull request includes the following: