[Refactor] Remove index-related utility code to parser module #62513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
This pull request refactors index-related utility code in the schema change handler, mainly by moving Bloom filter and inverted index validation logic out of the
analysis
package and into thesql.analyzer
package. It also updates how indexes are created and validated during schema changes, improving code organization and clarity.Refactoring and Code Organization
BloomFilterIndexUtil.java
andInvertedIndexUtil.java
from theanalysis
package, consolidating their logic intoIndexAnalyzer
in thesql.analyzer
package for better separation of concerns and maintainability. [1] [2] [3] [4]Index Creation and Validation Improvements
SchemaChangeHandler.java
to constructIndex
objects directly fromIndexDef
, and to assign index IDs only for compatible index types on OLAP tables, ensuring correct index metadata.IndexAnalyzer
instead of the removed utility class, centralizing validation logic.IndexAnalyzer.checkColumn
for consistent validation across index types.Minor Cleanups
tableRefToSql()
method fromTableRef.java
and deleted the now-unusedToSqlUtils.java
utility class, cleaning up obsolete code. [1] [2]What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: