Add support for Containerfile in addition to Dockerfile #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygalblum
force-pushed
the
suppport-container-file
branch
2 times, most recently
from
f734b96 to
567514a
Compare
|
Hold this review, I found an issue with the autocompletion script |
ygalblum
force-pushed
the
suppport-container-file
branch
from
567514a to
7702c6a
Compare
|
@eranco74 Found the issue and fixed it (there was actually an issue with the previous implementation as well) |
eranco74
approved these changes
May 11, 2023
ygalblum
force-pushed
the
suppport-container-file
branch
from
7702c6a to
dab6952
Compare
Also fix autocomplete Adjust unit tests Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
ygalblum
force-pushed
the
suppport-container-file
branch
from
dab6952 to
0a34b16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.