[SoundCloud] Fix SoundCloud HLS expiry and add extractor logging #1325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameters. Refactor documentation also
Add StreamingServiceId enum to map service id to name for logging
…rate building Hls and Progressive streams Add HlsAudioStream to facilitate refreshing expired Hls playlists
absurdlylongusername
changed the title
ShareASmile
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SoundCloud HLS stream urls expiring
This PR implements extractor side changes to facilitate refreshing expires HLS stream URLs for SoundCloud streams.
Add Extractor Logging
Added extractor logging, which helped a lot to fix this issue.
In a future PR I will add a proper logging framework that will only print logs if running in debug mode, but for now since the logs are not in high-traffic code then it should be fine.
Please Note
Includes changes from:
So those PRs must be merged before this.
See TeamNewPipe/NewPipe#12418 for the full writeup for the fix