feat: impact metrics migration #10551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
kwasniew
commented
Aug 27, 2025
| db.runSql( | ||
| ` | ||
| CREATE TABLE IF NOT EXISTS impact_metrics( | ||
| id TEXT NOT NULL PRIMARY KEY, |
There was a problem hiding this comment.
it will be ulid generated by code
kwasniew
commented
Aug 27, 2025
| ` | ||
| CREATE TABLE IF NOT EXISTS impact_metrics( | ||
| id TEXT NOT NULL PRIMARY KEY, | ||
| feature VARCHAR(255), |
There was a problem hiding this comment.
can be null for global impact metrics
kwasniew
commented
Aug 27, 2025
| CREATE TABLE IF NOT EXISTS impact_metrics( | ||
| id TEXT NOT NULL PRIMARY KEY, | ||
| feature VARCHAR(255), | ||
| config JSONB NOT NULL, |
There was a problem hiding this comment.
implicit schema for CRUD config
kwasniew
commented
Aug 27, 2025
| id TEXT NOT NULL PRIMARY KEY, | ||
| feature VARCHAR(255), | ||
| config JSONB NOT NULL, | ||
| FOREIGN KEY (feature) REFERENCES features(name) ON DELETE CASCADE |
There was a problem hiding this comment.
if related to feature it has to be a valid feature
Tymek
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
We want to store impact metrics configuration per flag. Previously we were storing impact metrics in global settings. This new table will accommodate both metrics for a flag and global ones (null feature field).
I decoded to model config as JSONB since we're not going to do any joins and we need to store data of this shape:
This is basically CRUD for this screen
Important files
Discussion points