Skip to content

Conversation

gowridurgad
Copy link
Contributor

Description:
Improves error handling to provide clearer messages when failures occur during Java setup, making it easier to identify the root cause of intermittent issues in workflows.

Related issue:
#793

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@gowridurgad gowridurgad marked this pull request as ready for review June 5, 2025 02:24
@Copilot Copilot AI review requested due to automatic review settings June 5, 2025 02:24
@gowridurgad gowridurgad requested a review from a team as a code owner June 5, 2025 02:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling during Java setup by enhancing log messages and better distinguishing between different HTTP error statuses. Key changes include:

  • Introducing a try-catch block around the package download logic.
  • Adding distinct error logging for HTTP 403 and 429 errors.
  • Rethrowing errors after logging their details for further propagation.
Comments suppressed due to low confidence (1)

src/distributions/base-installer.ts:87

  • Consider wrapping the caught error with additional context before rethrowing to aid downstream debugging. For example, throwing a new Error with a message that includes details about the failure may improve error traceability.
throw error;

@gowridurgad gowridurgad self-assigned this Jun 5, 2025
@HarithaVattikuti HarithaVattikuti merged commit ebb356c into actions:main Jun 23, 2025
364 checks passed
mergify bot added a commit to ArcadeData/arcadedb that referenced this pull request Aug 24, 2025
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.7.1 to 5.0.0.
Release notes

*Sourced from [actions/setup-java's releases](https://github.com/actions/setup-java/releases).*

> v5.0.0
> ------
>
> What's Changed
> --------------
>
> ### Breaking Changes
>
> * Upgrade to node 24 by [`@​salmanmkc`](https://github.com/salmanmkc) in [actions/setup-java#888](https://redirect.github.com/actions/setup-java/pull/888)
>
> Make sure your runner is updated to this version or newer to use this release. v2.327.1 [Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1)
>
> ### Dependency Upgrades
>
> * Upgrade Publish Immutable Action by [`@​HarithaVattikuti`](https://github.com/HarithaVattikuti) in [actions/setup-java#798](https://redirect.github.com/actions/setup-java/pull/798)
> * Upgrade eslint-plugin-jest from 27.9.0 to 28.11.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#730](https://redirect.github.com/actions/setup-java/pull/730)
> * Upgrade undici from 5.28.5 to 5.29.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#833](https://redirect.github.com/actions/setup-java/pull/833)
> * Upgrade form-data to bring in fix for critical vulnerability by [`@​gowridurgad`](https://github.com/gowridurgad) in [actions/setup-java#887](https://redirect.github.com/actions/setup-java/pull/887)
> * Upgrade actions/checkout from 4 to 5 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#896](https://redirect.github.com/actions/setup-java/pull/896)
>
> ### Bug Fixes
>
> * Prevent default installation of JetBrains pre-releases by [`@​priyagupta108`](https://github.com/priyagupta108) in [actions/setup-java#859](https://redirect.github.com/actions/setup-java/pull/859)
> * Improve Error Handling for Setup-Java Action to Help Debug Intermittent Failures by [`@​gowridurgad`](https://github.com/gowridurgad) in [actions/setup-java#848](https://redirect.github.com/actions/setup-java/pull/848)
>
> New Contributors
> ----------------
>
> * [`@​gowridurgad`](https://github.com/gowridurgad) made their first contribution in [actions/setup-java#848](https://redirect.github.com/actions/setup-java/pull/848)
> * [`@​salmanmkc`](https://github.com/salmanmkc) made their first contribution in [actions/setup-java#888](https://redirect.github.com/actions/setup-java/pull/888)
>
> **Full Changelog**: <actions/setup-java@v4...v5.0.0>


Commits

* [`dded088`](actions/setup-java@dded088) Bump actions/checkout from 4 to 5 ([#896](https://redirect.github.com/actions/setup-java/issues/896))
* [`0913e9a`](actions/setup-java@0913e9a) Upgrade to node 24 ([#888](https://redirect.github.com/actions/setup-java/issues/888))
* [`e9343db`](actions/setup-java@e9343db) Bumps form-data ([#887](https://redirect.github.com/actions/setup-java/issues/887))
* [`ae2b61d`](actions/setup-java@ae2b61d) Bump undici from 5.28.5 to 5.29.0 ([#833](https://redirect.github.com/actions/setup-java/issues/833))
* [`c190c18`](actions/setup-java@c190c18) Bump eslint-plugin-jest from 27.9.0 to 29.0.1 ([#730](https://redirect.github.com/actions/setup-java/issues/730))
* [`67aec00`](actions/setup-java@67aec00) Fix: prevent default installation of JetBrains pre-releases ([#859](https://redirect.github.com/actions/setup-java/issues/859))
* [`ebb356c`](actions/setup-java@ebb356c) Improve Error Handling for Setup-Java Action to Help Debug Intermittent Failu...
* [`f4f1212`](actions/setup-java@f4f1212) Update publish-immutable-actions.yml ([#798](https://redirect.github.com/actions/setup-java/issues/798))
* See full diff in [compare view](actions/setup-java@c5195ef...dded088)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/setup-java&package-manager=github\_actions&previous-version=4.7.1&new-version=5.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants