Update brotli to use master branch #204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project doesn't seem to use tags in Github. The brotli submodule got an update last year: google/ngx_brotli@9aec15e I think we are safe to use it. I think we should let both lines commented out for the small chance to change back.
MaximeMichaud
suggested changes
Nov 8, 2021
| git submodule update --init | ||
| # Use the master branch for now | ||
| #git checkout v1.0.0rc | ||
| #git submodule update --init |
There was a problem hiding this comment.
Hi, this line "#git submodule update --init" need to be uncommented or:
There was a problem hiding this comment.
I thought I have tested it. I thought this command is only required if a checkout comment is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project doesn't seem to use tags in Github.
The brotli submodule got an update last year: google/ngx_brotli@9aec15e
I think we are safe to use it.
I think we should let both lines commented out for the small chance to change back.